Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libyaml headers to builder image. #56

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add libyaml headers to builder image. #56

merged 1 commit into from
Oct 11, 2023

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Oct 11, 2023

The psych gem needs to compile against libyaml.

Not sure why we're only running into this now — maybe Rails was happy with our stock version of psych until recently? — but in any case it seems sensible to include headers in the builder image for libraries that we ship in our base image.

The `psych` gem needs to compile against libyaml.

Not sure why we're only running into this now (maybe Rails was happy
with our stock version of `psych` until recently?) but in any case it
seems sensible to include headers in the builder image for libraries
that we ship in our base image.
@sengi sengi requested review from aldavidson and AgaDufrat October 11, 2023 11:18
Copy link

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sengi sengi merged commit 3bca83f into main Oct 11, 2023
2 checks passed
@sengi sengi deleted the sengi/libyaml branch October 11, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants